View Full Version : Search function


sowega
March 30th, 2016, 09:41 AM
Doesn't seem to be working. Page loads are taking longer than usual, as well.

sowega
March 30th, 2016, 09:42 AM
Search function works now. Nevermind

Alex
March 30th, 2016, 11:47 AM
The pulldown menu has links to two separate types of searching. The first couple go to the internal vbulletin search engine, the last one goes to a filtered google search for this site. There is no link behind the scenes from one to the other.

If the error seems to be that the pulldown menu to go to the search options is popping up slowly (or not loading at all), it's not a search problem. It's a page load issue, where that pulldown menu is loading last, and one of the ads is likely hanging. The site and page is configured so that shouldn't happen, the ads should load afterwards and not hold up anything else, but I have noticed that it seems to have an effect from time to time. I'm not sure if that is badly written code on Google's side, or on a lack of filtering in their ad program for the providers that the ads are actually coming from (Google is often just a passthrough).

crazymadbastard
March 30th, 2016, 12:41 PM
The pulldown menu has links to two separate types of searching. The first couple go to the internal vbulletin search engine, the last one goes to a filtered google search for this site. There is no link behind the scenes from one to the other.

If the error seems to be that the pulldown menu to go to the search options is popping up slowly (or not loading at all), it's not a search problem. It's a page load issue, where that pulldown menu is loading last, and one of the ads is likely hanging. The site and page is configured so that shouldn't happen, the ads should load afterwards and not hold up anything else, but I have noticed that it seems to have an effect from time to time. I'm not sure if that is badly written code on Google's side, or on a lack of filtering in their ad program for the providers that the ads are actually coming from (Google is often just a passthrough).



:nerd:




.

csmith12
March 30th, 2016, 12:50 PM
:nerd:

http://i63.tinypic.com/33m4nkw.jpg

I noticed it too and snagged this pic.

Alex
March 30th, 2016, 12:52 PM
Interesting. The Godaddy call is supposed to be non-modal/non-blocking, loading at the end in the footer. If it hanging is keeping the rest of the page from loading, I'll just pull that seal (it's not buying much anyway).

Alex
March 30th, 2016, 12:57 PM
Commented out the GoDaddy seal. Let's see if it makes a difference over the next few days (please post up here if you notice things one way or the other).

csmith12
March 30th, 2016, 01:29 PM
Alex

Any script tag within the body tags will block until the script is downloaded. Without altering the code too much you could add the async property to the script tag. Possibly that will help with the vast majority of ninjette users and let it delay load since it's not a vital function.


<script async type="text/javascript" src="https://seal.godaddy.com/getSeal?sealID=

csmith12
March 30th, 2016, 01:42 PM
An alternate solution is to host the seal image locally and then update the html to something like this.

[code]
<a target="_blank" href="https://seal.godaddy.com/verifySeal?sealID=XXXXXXXXX"
><img src="/images/siteseal.gif" alt="Siteseal"></a>
[/[code]]

Alex
March 30th, 2016, 02:05 PM
Getting the seal isn't just displaying a standard image, that script verifies that this site really is GoDaddy verified from the perspective of their servers, and returns the appropriate image. Not sure how much people care about that though, so I don't have much heartburn about removing it entirely if appropriate.

I added the async flag and uncommented it, please let me know if you are seeing any slowness directly attributed to it still.

Alex
March 30th, 2016, 02:08 PM
Hmm, the async tag didn't seem to work. Here's the actual code (anonymized)

<span id="siteseal"><script type="text/javascript" src="https://seal.godaddy.com/getSeal?sealID=xxxxxxxxxxxxxxxxxxx"></script></span>

when I changed it to:

<span id="siteseal"><script async type="text/javascript" src="https://seal.godaddy.com/getSeal?sealID=xxxxxxxxxxxxxxxxxxx"></script></span>

It never displayed the image.

InvisiBill
April 21st, 2016, 05:49 PM
http://www.w3schools.com/tags/att_script_async.asp
In XHTML, attribute minimization is forbidden, and the async attribute must be defined as <script async="async">.

While we're on the subject, the validator is complaining (http://validator.w3.org/check?uri=https%3A%2F%2Fwww.ninjette.org%2F&charset=%28detect+automatically%29&doctype=Inline&group=0) about an extra "-" in the closing comment tag for the Google Analytics. The first "--" actually ends the comment, so the third "-" before the closing ">" makes it unhappy.

Alex
April 21st, 2016, 06:04 PM
Ugh! Can't find the actual template where that code for the analytics is! The search function doesn't seem to be working within that template search module. Will try again when I get home...

Alex
April 23rd, 2016, 09:34 AM
So strange. It's not in any templates, because I'm using a tiny plug-in on the site that inserts the google analytics code block in automatically. I thought that would be easier than maintaining the template changes over time. But there is nothing in that plug-in that has that commenting to change. Can't find it in the templates, can't find it in the source code, can't find it at all. If it's showing up in the page source, it's certainly here somewhere, but no luck yet.